hasura/graphql-engine

Add support for Docker Secrets by reading secrets files

オープン

#3,989 opened on 2020/03/02

 (19 件のコメント) (27 件のリアクション) (1 人の担当者)TypeScript (2,787 件のフォーク)batch import
a/securityc/serverhelp wantedk/enhancement

Repository metrics

Stars
 (31,371 個のスター)
PR merge metrics
 (PR metrics pending)

説明

Currently, the only way to pass secrets (DB credentials, Hasura admin secret) to Hasura is only by environment variables. For users of Docker Compose or Docker Swarm, this means these secrets have to be stored in plaintext, which presents security risks.

It would be great to build support for Docker Secrets (or even Vault), by adding the following environment variables, as recommended by Docker:

  • HASURA_GRAPHQL_ACCESS_KEY_FILE
  • HASURA_GRAPHQL_DATABASE_URL_FILE

If these variables are present, the access key and DB URL should be read from the corresponding files.

Docs: https://docs.docker.com/engine/swarm/secrets/#build-support-for-docker-secrets-into-your-images

コントリビューターガイド