haskell/haskell-ide-engine

Suggstion: ship with profiling disabled via stack-8.x.x.yaml

Open

#1,248 opened on 2019年5月8日

GitHub で見る
 (5 comments) (0 reactions) (0 assignees)Haskell (2,358 stars) (205 forks)batch import
Well Defined Task - Awaiting PRbuildgardening 🌱good first issue

説明

Related to #1214, which reports that building with profiling on under stack doesn't work.

Some developers may have profiling on by default with stack (i.e. library-profiling: true and executable-profiling: true in ~/.stack/config.yaml). I do this because I want profiling on more often than I want it off, and because it takes a long time to switch between profiling and non-profiling builds with stack. This configuration caused building HIE to fail and it took quite a while to figure out why.

As long as profiling doesn't work out of the box with stack, might it make sense ship with profiling explicitly disabled in stack-8.x.x.yaml?

build:
  library-profiling: false
  executable-profiling: false

コントリビューターガイド

技術スタック
なし
領域
build systemtooling
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
under 1 hour
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Basic knowledge of Stack build toolUnderstanding of profiling flags
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
60
調査方針
Look at the file stack 8.x.x.yaml in the repository. The suggestion is to add build configuration options to disable profiling explicitly. Refer to the related issue #1214 for context on why profiling causes build failures. Check if there are any recent comments or updates on this issue to ensure the approach is still valid.