hashicorp/packer

The -NonInteractive Parameter should be added by default when starting a powershell shell

Open

#12,637 opened on 2023年9月27日

GitHub で見る
 (3 comments) (2 reactions) (0 assignees)Go (13,697 stars) (3,228 forks)batch import
enhancementhelp wantedprovisioner/powershell

説明

When a script called by the Powershell provisioner includes a command that involves a y/n prompt (or other kinds of interaction (e.g., Read-Host) the Powershell script will appear to hang as that script will wait indefinitely for the input. The -NonInteractive Parameter should be added by default when using the Powershell provisioner. This would result in an error instead of the apparent hanging when using commands requiring interactivity.

This can currently be worked around by specifying a custom execute_command, but it would be preferable to set the parameter by default.

Originally posted by @floh96 in https://github.com/hashicorp/packer/issues/4916#issuecomment-1239297541

コントリビューターガイド

技術スタック
goshell
領域
devopsinfrastructure
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
fresh
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Go programmingPacker provisionersPowerShell
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
65
調査方針
Look at the PowerShell provisioner code in Packer, likely in the 'provisioner/powershell' directory. The issue references a workaround using custom execute command; the fix involves adding ' NonInteractive' to the default command. Check how the default execute command is constructed and where to add the parameter. There is no linked PR or assignee, so this is available for a new contributor.
The -NonInteractive Parameter should be added by default when starting a powershell shell · hashicorp/packer#12637 | Good First Issue