guardicore/monkey

Invalid configurations can be exported in the UI

オープン

#3,703 opened on 2023/09/15

 (0 件のコメント) (0 件のリアクション) (0 人の担当者)Python (752 件のフォーク)batch import
BugComplexity: MediumHelp wantedImpact: LowUI

Repository metrics

Stars
 (6,250 個のスター)
PR merge metrics
 (PR metrics pending)

説明

Describe the bug

While an invalid configuration can't be submitted through the UI, it can be exported.

Trying to import that configuration in the UI isn't allowed, so it could be frustrating for a user who didn't realise that some values were invalid while exporting.

To Reproduce

Steps to reproduce the behavior:

  1. Run Island
  2. Add invalid configuration value somewhere
  3. Try submitting and see warning box
  4. Export and check the exported configuration for invalid value

Expected behavior

Don't allow exporting configuration if some values are invalid.

Screenshots

  1. Added invalid IP to configuration image

  2. Export modal works normally, but a warning is shown on the configuration page image

  3. Warning box image

  4. Exported configuration image

コントリビューターガイド