grpc/grpc-java

Recommended IntelliJ code style settings are out of date

Open

#617 opened on 2015年7月10日

GitHub で見る
 (5 comments) (0 reactions) (0 assignees)Java (3,742 forks)batch import
help wanted

Repository metrics

Stars
 (11,124 stars)
PR merge metrics
 (平均マージ 23d 22h) (30d で 43 merged PRs)

説明

I downloaded and imported the GoogleStyle code style settings xml, as recommended in Contributing.md. It doesn't seem like this project and its checkstyle are actually conforming to those style settings (which is fine, I like the prevailing gRPC style better!) A few things in particular keep coming up:

  • Import order: GoogleStyle has static imports at the bottom, doesn't separate grpc imports. This is configured in Code Style > Java > Imports > Import Layout.
  • Method argument wrapping: GoogleStyle has method call arguments and declaration parameters on the next line aligned to the opening paren. This is configured in Code Style > Java > Wrapping and Braces > Method declaration parameters > Align when multiline, as well as the same option under Method call arguments.

コントリビューターガイド