grafana/k6

Address jhump/protoreflect deprecations introduced by v1.17.0

Open

#4,035 opened on 2024年11月4日

GitHub で見る
 (4 comments) (0 reactions) (1 assignee)Go (30,564 stars) (1,537 forks)batch import
enhancementgood first issue

説明

As we bumped our github.com/jhump/protoreflect/desc dependency to v0.17.0 we decided to postpone addressing the deprecations this specific version introduced.

Specifically:

  • github.com/jhump/protoreflect/desc is now considered deprecated.

This package is now deprecated. Though use of this package is still needed in order to use a handful of other packages in this repo, many usages should instead prefer the "google.golang.org/protobuf/reflect/protoreflect" package in the Protobuf runtime. In a v2 of this repo, this package will no longer be present.

  • github.com/jhump/protoreflect/desc/protoparse is now considered deprecated.

This package is now deprecated. Most usages should instead prefer the "github.com/bufbuild/protocompile" package. There are some behavioral differences that we hope to address with additional API and enhancements to protocompile. But the protoparse package here is just a veneer on top of protocompile and we plan to do as little maintenance as possible here. In a v2 of this repo, this package will no longer be present.

As a result we have a couple of //nolint:staticcheck comments ignoring those deprecations explicitly. Those can be found in the following files:

Definition of done

We have replaced the deprecated packages import with their more modern counterparts, and the nolint statements have been removed.

コントリビューターガイド

技術スタック
go
領域
backendtestingperformance
Issue 種別
refactor
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
active
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Go programmingprotobuf basicsk6 codebase familiarity
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
60
調査方針
The issue involves replacing deprecated packages from jhump/protoreflect with their modern counterparts (google.golang.org/protobuf and bufbuild/protocompile). The specific files requiring changes are listed: lib/netext/grpcext/reflect.go, lib/netext/grpcext/conn test.go, and js/modules/k6/grpc/client.go (appears twice). The maintainer should first review the updated dependency's documentation and the linked release notes to understand the new APIs. Then, systematically replace each import and adjust usage accordingly. Finally, remove the //nolint:staticcheck comments. Testing is crucial to ensure functionality remains intact.