grafana/k6

Run tests in separate process so that we actually test loading proto definitions at runtime

Open

#3,552 opened on 2023年7月5日

GitHub で見る
 (1 comment) (0 reactions) (0 assignees)Go (30,564 stars) (1,537 forks)batch import
area: grpccihelp wantedtests

説明

Originally raised in this comment by @thiagodpf.

What?

The current unit tests run the server and clients in the same process.

gRPC seems to have a global registry for types, so once the server loads them, the client doesn't need to.

This means that all tests that test that clients actually manage to load types correctly only with .proto files are not actually testing that :(

Solutions:

Preferably go test ./... should run the unit tests with the server and client as separate process - preferably even separate from the main go test one :thinking:

This sounds involved.

A quicker solution will be to have another CI step that runs a server + k6 run script.js exercising the most common cases.

Both will be best.

コントリビューターガイド

技術スタック
gojavascript
領域
testing
Issue 種別
test
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-2 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
fresh
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
Go programmingtesting experiencegRPC basics
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
30
調査方針
Investigate the current test structure in the k6 repository, particularly around gRPC tests. The issue references a comment in issue #3160. Consider implementing a CI step that runs a server and executes 'k6 run script.js' to test proto loading, or refactor unit tests to use separate processes. Review the existing test files for gRPC and the CI configuration (e.g., GitHub Actions workflows) to determine the best approach.
Run tests in separate process so that we actually test loading proto definitions at runtime · grafana/k6#3552 | Good First Issue