grafana/grafana

ID 256753: [Keyboard Navigation - Simon - Settings>Row options]: Row options pop-up is getting closed while closing 'Repeat for' combo box via esc key.

Open

#72,806 opened on 2023年8月3日

GitHub で見る
 (5 comments) (0 reactions) (0 assignees)TypeScript (73,744 stars) (13,868 forks)batch import
MASarea/frontendhacktoberfesthelp wantedteam/grafana-dashboardstype/accessibilitywcag-level/AA

説明

User Experience:

Users who depend on keyboard as well as screen reader will find it difficult to reach to the same control if users try to close combo-box with ESC key but whole dialog will get closed. Note: User credentials should NOT be included in the bug.

Repro Steps:

  1. Open #Url: play.grafana.org. Sign in with valid credentials. "Home" page appears.
  2. Navigate the Feature Showcase pane. Select any one of the data such as ,"Time Series Graphs". "Visualizations" page opens.
  3. Navigate to the "Multiple Y-axis" pane and expand it. Select the "Settings" button of the pane, "Row Options" pane appears.
  4. Navigate the "Row Options" pop-up.
  5. Try to select an option in the drop down
  6. Verify the issue.

Actual Result: Row options pop-up is getting closed while closing 'Repeat for' combo box via esc key.

Expected Result: Row options pop-up should not get close while closing 'Repeat for' combo box via esc key. Note: Same issue exists with throughout the application.

### Severity: SEV3

Area:

PanelHeaderMenuTrigger Component

コントリビューターガイド

技術スタック
typescriptreact
領域
frontendaccessibility
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Reactkeyboard event handlingaccessibilityGrafana UI components
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
60
調査方針
Investigate the PanelHeaderMenuTrigger component in the Grafana codebase, specifically the keyboard event handler for the 'Repeat for' combo box. The ESC key should close only the combo box, not the entire row options pop up. Look at how other similar dropdown menus handle ESC key propagation and ensure event.stopPropagation() is used appropriately.