gorhill/uBlock-for-firefox-legacy

Input fields looks inconsistent on dark GTK themes

オープン

#302 opened on 2021/04/10

 (1 件のコメント) (0 件のリアクション) (0 人の担当者)JavaScript (24 件のフォーク)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (211 個のスター)
PR merge metrics
 (30d に merged PR はありません)

説明

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

Input fields and select menus looks inconsistent with uBO theme, when dark GTK theme is enabled.

2021-04-10_18-48

2021-04-10_18-49

I think that's the best solution currently:

input, select {
    color: var(--default-ink);
    background-color: var(--default-surface);
}

It's not ideal, cuz arrows on input field number and select menus still will be dark.

Mozilla fixed that in https://bugzilla.mozilla.org/show_bug.cgi?id=1527048 for webpages and out of process webextensions.

Maybe even better solution would be to make dark mode for uBO .

A specific URL where the issue occurs

chrome://ublock0/content/dashboard.html#1p-filters.html chrome://ublock0/content/logger-ui.html

Steps to Reproduce

  1. Switch to GTK dark theme
  2. Run Basilisk and uBO
  3. Go to Dashboard or Logger

Expected behavior:

Input fields and select menus should have same background color as other elements.

Actual behavior:

Input fields and select menus are matched to dark GTK theme.

Your environment

  • uBlock Origin version: uBlock Origin v1.16.4.28
  • Browser Name and version: Basilisk 2021.03.17
  • Operating System and version: Manjaro 21.0.1 Ornara

コントリビューターガイド