googlefonts/glyphsLib

Handle default layer with custom name

オープン

#619 opened on 2020/08/17

 (0 件のコメント) (1 件のリアクション) (0 人の担当者)Python (55 件のフォーク)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (198 個のスター)
PR merge metrics
 (30d に merged PR はありません)

説明

https://unifiedfontobject.org/versions/ufo3/layercontents.plist/ says:

public.default

This layer name indicates that the default layer has no user defined name. It must not be used as the layer name for any directory other than the default glyphs directory.

GlyphLib assumes the default layer has no user defined name but that may not be the case. https://github.com/googlefonts/glyphsLib/blob/638cbddd00b2334410bab914d932bf673d6342ca/Lib/glyphsLib/builder/layers.py#L74 Instead it should check that the layer is font.layers.defaultLayer or that its name is font.layers.defaultLayer.name.

コントリビューターガイド