google/comprehensive-rust

Rewrite speaker note system

Open

#1,232 opened on 2023年9月22日

GitHub で見る
 (1 comment) (0 reactions) (0 assignees)Rust (2,009 forks)batch import
good first issuehelp wanted

Repository metrics

Stars
 (32,954 stars)
PR merge metrics
 (平均マージ 9d 23h) (30d で 36 merged PRs)

説明

The speaker-notes.js file is a little home-grown system for injecting speaker notes to the pages.

I would like to rewrite this to use a more modern development style:

  • we should minimize the code when publishing the course
  • we should make the label ("Speaker Notes") translatable!
  • we could perhaps use a library for some of the state logic?
  • we could take advantage of https://github.com/google/mdbook-i18n-helpers/issues/70 when it's ready to do less on the fly DOM manipulation

コントリビューターガイド