google/benchmark

Warnings C4244, C4305, C4722, ... when compiling with MS Visual Studio 2017 15.9.12

Open

#826 opened on 2019年6月4日

GitHub で見る
 (5 comments) (0 reactions) (0 assignees)C++ (7,968 stars) (1,539 forks)batch import
buggood first issuehelp wantedos:windows

説明

googlebenchmark\src\benchmark_runner.cc(267): warning C4244: 'initializing': conversion from 'double' to 'benchmark::IterationCount', possible loss of data googlebenchmark\src\benchmark_runner.cc(267): warning C4244: 'initializing': conversion from 'double' to 'const benchmark::IterationCount', possible loss of data d:\thirdparty\trunk\googlebenchmark\test\statistics_gtest.cc(25): warning C4305: 'argument': truncation from 'double' to 'RawType' googlebenchmark\test\statistics_gtest.cc(24): warning C4244: 'argument': conversion from 'double' to 'RawType', possible loss of data googlebenchmark\src\benchmark_register.h(25): warning C4244: '=': conversion from 'int' to 'T', possible loss of data googlebenchmark\third_party\googletest\src\googlemock\include\gmock\gmock-matchers.h(156): warning C4244: 'argument': conversion from 'const M' to 'const Element', possible loss of data googlebenchmark\src\check.h(41): warning C4722: 'benchmark::internal::CheckHandler::~CheckHandler': destructor never returns, potential memory leak googlebenchmark\src\benchmark_runner.cc(267): warning C4244: 'initializing': conversion from 'double' to 'benchmark::IterationCount', possible loss of data googlebenchmark\src\benchmark_runner.cc(267): warning C4244: 'initializing': conversion from 'double' to 'const benchmark::IterationCount', possible loss of data googlebenchmark\src\check.h(41): warning C4722: 'benchmark::internal::CheckHandler::~CheckHandler': destructor never returns, potential memory leak googlebenchmark\test\statistics_gtest.cc(25): warning C4305: 'argument': truncation from 'double' to 'RawType' googlebenchmark\test\statistics_gtest.cc(24): warning C4244: 'argument': conversion from 'double' to 'RawType', possible loss of data googlebenchmark\src\check.h(41): warning C4722: 'benchmark::internal::CheckHandler::~CheckHandler': destructor never returns, potential memory leak googlebenchmark\src\check.h(41): warning C4722: 'benchmark::internal::CheckHandler::~CheckHandler': destructor never returns, potential memory leak googlebenchmark\src\check.h(41): warning C4722: 'benchmark::internal::CheckHandler::~CheckHandler': destructor never returns, potential memory leak googlebenchmark\src\benchmark_register.h(25): warning C4244: '=': conversion from 'int' to 'T', possible loss of data googlebenchmark\third_party\googletest\src\googlemock\include\gmock\gmock-matchers.h(156): warning C4244: 'argument': conversion from 'const M' to 'const Element', possible loss of data googlebenchmark\src\check.h(41): warning C4722: 'benchmark::internal::CheckHandler::~CheckHandler': destructor never returns, potential memory leak googlebenchmark\src\check.h(41): warning C4722: 'benchmark::internal::CheckHandler::~CheckHandler': destructor never returns, potential memory leak

コントリビューターガイド

技術スタック
cpp
領域
developer experience
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Basic C++ knowledgeFamiliarity with MSVC warnings
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
70
調査方針
Review the specific warnings in files: benchmark runner.cc (line 267), statistics gtest.cc (lines 24-25), benchmark register.h (line 25), check.h (line 41). Determine appropriate fixes: either add explicit static cast or change variable types to avoid precision loss. For check.h warning C4722, consider whether the destructor should be noreturn or if the warning can be suppressed with a pragma. No existing PRs or assignees, so the issue is open for contribution.