google/benchmark

[FR] Allow ThreadRange Multiplier to be different from Arg Ranges one

Open

#1,531 opened on 2023年1月16日

GitHub で見る
 (0 comments) (1 reaction) (0 assignees)C++ (7,968 stars) (1,539 forks)batch import
enhancementhelp wanted

説明

Is your feature request related to a problem? Please describe. Once a RangeMultiplier is set, the threadrange also uses the exact same one, it would be easier if one could either set a ThreadRangeMultiplier or a multiplier argument to ThreadRange(min,max,multiplier)

Describe the solution you'd like A simple solution could be accepting a multiplier argument to the the ThreadRange arguments which can be used in case you'd need a customization on ThreadRange different from RangeMultiplier

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

コントリビューターガイド

技術スタック
cpp
領域
performance
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
C++Google Benchmark library basics
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
65
調査方針
Start by examining the current implementation of ThreadRange and RangeMultiplier in the benchmark library. The relevant code is likely in include/benchmark/benchmark.h and src/benchmark.cc. Implement an additional parameter for multiplier in ThreadRange, following the pattern of the existing RangeMultiplier. Then update the documentation and tests accordingly.
[FR] Allow ThreadRange Multiplier to be different from Arg Ranges one · google/benchmark#1531 | Good First Issue