google/benchmark

[FR] cc_libraries should use "includes", not "strip_include_prefix"

オープン

#1,512 opened on 2022/11/16

 (3 件のコメント) (1 件のリアクション) (0 人の担当者)C++ (1,539 件のフォーク)batch import
enhancementhelp wanted

Repository metrics

Stars
 (7,968 個のスター)
PR merge metrics
 (PR metrics pending)

説明

So that when users import google-benchmark, the headers are included as "system headers", instead of regular headers.

If this is not done, compilers will throw warnings at google-benchmark code, which users have no way to act upon. Users should be able to choose a highly restrictive set of warnings without having to fix them in google-benchmark.

Note that this pattern is already applied in the googletest repo.

コントリビューターガイド