cmd/vet: warn about unused struct or array, ignoring assignment to field or element · golang/go#449

2009-12-22T02:14:21.000Z

by **RyanneDolan**: What steps will reproduce the problem? v := new(struct{i int}) v.i = 1 What is the expected output? What do you see instead? Should get "v declared and not used" error. Instead, compiles fine. What is your $GOOS? $GOARCH? linux/386 Which revision are you using? (hg identify) 54392bd03d06 tip Please provide any additional information below. The dot operator should mark its left operand as "used" only when it appears on the RHS. a = 1 // 'a' is not marked as used (CORRECT) v.i = 1 // 'v' is marked as used (WRONG) a = v.i // 'v' is marked as used (CORRECT) This bug is important to fix for consistency, and because it confuses new programmers who might expect reference semantics: for _,v := range arr {v.i = 1} // doesn't do anything Mentioned here: http://groups.google.com/group/golang- nuts/browse_thread/thread/342fe61c78916496/fbb57f693f1aca72

(9 comments) (0 reactions) (0 assignees)Go (19,008 forks)batch import

AnalysisNeedsFixhelp wanted

Repository metrics

Stars: (133,883 stars)
PR merge metrics: (30d に merged PR はありません)

説明

by RyanneDolan:

コントリビューターガイド

調査方針: cmd/vetツールのコードを検査し、構造体フィールドや配列要素への代入が左辺のオペランドを使用済みとしてマークする場所を見つけ、式が右辺に現れた場合のみ使用済みとしてマークするように修正します。
技術スタック: go
領域: backend
Issue 種別: バグ
難度: 2
推定時間: 1-3時間
活動状況: アクティブ
明確さ: 明確
前提条件: Go
初心者向け度: 60

Repository metrics

説明

コントリビューターガイド

新着 Easy issues をメールで受け取る。