go-kit/kit

SD - Registrator error handling

オープン

#780 opened on 2018/10/23

 (1 件のコメント) (0 件のリアクション) (0 人の担当者)Go (2,446 件のフォーク)batch import
enhancementhelp wantednewbie friendly

Repository metrics

Stars
 (27,422 個のスター)
PR merge metrics
 (30d に merged PR はありません)

説明

Is there any reason for not returning any error on the registration of a service? https://github.com/go-kit/kit/blob/ec0cc13a9b00d1214c9b7ae63d7b750626b54c6d/sd/registrar.go#L11

From my point of view, if a service doesn't manage to correctly register, then it might be nice to retry later. Binding to events to watch if you're correctly registered seems overkilled compared to just checking this error.

What are your thoughts?

コントリビューターガイド