go-chi/chi

Refactor throttle middleware tests as prone to intermittent failure

オープン

#608 opened on 2021/03/25

 (4 件のコメント) (0 件のリアクション) (0 人の担当者)Go (555 件のフォーク)batch import
help wanted

Repository metrics

Stars
 (8,127 個のスター)
PR merge metrics
 (平均マージ 16h 36m) (30d で 2 merged PRs)

説明

https://github.com/go-chi/chi/blob/master/middleware/throttle_test.go

It's often that when I submit a PR, and the code runs through github ci, it will fail -- https://github.com/go-chi/chi/actions

I have to re-run the jobs to have it pass, it seems to be a timing issue. When running locally, it seems to work well pretty consistently, but I've seen the rare failing case.

コントリビューターガイド