glue-viz/glue-openspace

Avoid removing and adding graph node when updating properties

オープン

#1 opened on 2019/06/26

 (0 件のコメント) (0 件のリアクション) (0 人の担当者)Python (4 件のフォーク)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (2 個のスター)
PR merge metrics
 (30d に merged PR はありません)

説明

At the moment, whenever any aspect of a layer is changed, we remove the graph node from OpenSpace and add a new one (this is done in layer_artist.py). We should make sure that we only add the graph node once and then make updates by setting only the properties that need to be set. This can include:

  • Changing the data to be shown (e.g. if a subset changes, or the attributes for the RA/Dec change)
  • Color
  • Visibility
  • Transparency
  • Point size/brightness

コントリビューターガイド