Code cleanup: Can we remove the nested functions pattern of util.assertFns? · globalizejs/globalize#361

(0 comments) (0 reactions) (0 assignees)JavaScript (4,759 stars) (645 forks)batch import

help wantedquick change

説明

Ref: https://github.com/jquery/globalize/pull/351/files#r21450932

util.assertCurrencyParameter( assert, "currency", function( invalidValue ) {
 return function() {
    Globalize.currencyFormatter( invalidValue );
  };
});

@jzaefferer

I guess we've discussed this before as well, still doesn't make much sense: Why does this test have to return two nested functions?

@rxaviers

Yeap, we have discussed about this and it was clear this was needed. Although, I also believe this could be simplified.

コントリビューターガイド

技術スタック: javascript
領域: localizationtesting
Issue 種別: refactor
難度: 2
推定時間: 1-3 hours
活動状況: stale
明確さ: mostly clear
前提条件: JavaScriptUnderstanding of Globalize test utilities
初心者向け度: 75
調査方針: Review the linked pull request #351 to understand the current nested function pattern. Then, search the codebase for uses of util.assertFns and similar patterns. Propose a refactored version that removes the nested functions while preserving functionality. Check for any existing tests that depend on the current shape.