glideapps/quicktype

Generate ComponentModel.DataAnnotations attributes for JSON Schema constraints

Open

#825 opened on 2018年4月25日

GitHub で見る
 (0 comments) (0 reactions) (0 assignees)TypeScript (10,867 stars) (968 forks)batch import
C#JSON Schemagood first issue

説明

There are attributes for min/max and regular expressions, maybe more. I'm not sure they're checked by Json.NET when deserializing, but it would nice to have them in general. Also, the JSON Schema generator of Json.NET will use them to reproduce the constraints in the schema.

コントリビューターガイド

技術スタック
typescript
領域
toolingdeveloper experience
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-2 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
Knowledge of C# DataAnnotationsUnderstanding of JSON Schema
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
40
調査方針
This issue requests adding DataAnnotation attributes (such as MinLength, MaxLength, RegularExpression) to generated C# classes based on JSON Schema constraints. To implement, examine how quicktype currently generates C# code (likely in src/quicktype core/language/CSharp.ts) and how JSON Schema constraints are processed in the schema processing pipeline. The comment mentions that Json.NET's JSON Schema generator uses these attributes, so it would be beneficial for round tripping. There are no prior discussions or PRs to reference, so the implementation should start by adding support for the most common string constraints and ensuring they are emitted when generating C# code.
Generate ComponentModel.DataAnnotations attributes for JSON Schema constraints · glideapps/quicktype#825 | Good First Issue