Swift 5.9 warning about Hashable being deprecated · glideapps/quicktype#2423

(0 comments) (0 reactions) (0 assignees)TypeScript (10,867 stars) (968 forks)batch import

Swiftgood first issue

説明

Generate swift code has compilation warning about deprecated protocol.

SamSchema.swift:5645:16: warning: 'Hashable.hashValue' is deprecated as a protocol requirement; conform type 'JSONNull' to 'Hashable' by implementing 'hash(into:)' instead
    public var hashValue: Int {

Using :

swift --version 
swift-driver version: 1.87.1 Apple Swift version 5.9 (swiftlang-5.9.0.128.108 clang-1500.0.40.1)
Target: arm64-apple-macosx14.0

Steps to reproduce :

curl -o sam.schema.json https://raw.githubusercontent.com/aws/serverless-application-model/develop/schema_source/sam.schema.json

quicktype -s schema sam.schema.json -o SamSchema.swift

swift SamSchema.swift 
SamSchema.swift:5645:16: warning: 'Hashable.hashValue' is deprecated as a protocol requirement; conform type 'JSONNull' to 'Hashable' by implementing 'hash(into:)' instead
    public var hashValue: Int {

Expected behaviour : generated code is updated to not include deprecated features.

Thanks !

コントリビューターガイド

技術スタック: swifttypescript
領域: tooling
Issue 種別: bug
難度: 2
推定時間: under 1 hour
活動状況: fresh
明確さ: clear
前提条件: Basic Swift knowledgeFamiliarity with quicktype's codebase
初心者向け度: 80
調査方針: The issue is about updating Swift code generation to replace deprecated 'Hashable.hashValue' with 'hash(into:)'. Look at quicktype's Swift code generation templates, likely in src/language/Swift. Find where JSONNull conforms to Hashable and implement the hash(into:) method. Test by generating Swift code from the SAM schema and verifying no warnings.