glideapps/quicktype
GitHub で見るpython: invalid code due to comments starting or ending with double quotes
Open
#1,239 opened on 2019年5月23日
Pythonbuggood first issue
説明
when generating python code, the generated syntax becomes invalid if there are comments (i.e. "description" fields in the JSON schema) that start or end with double quotes
Example
for the JSON schema fragment:
"properties": {
"type": {
"description": "type is \"output\"",
"minLength": 1,
"oneOf": [
{
"$ref": "#/definitions/MessageType"
}
]
},
the generated (invalid) python 3.7 code fragment is
"""type is "output""""
type: MessageType
Solution
the generator for python should check the first and last character of a documentation-comment (i.e. the "description" field value) -- and if this is the case, the emitted code should "escape" these characters (e.g. prepend/append a newline or space character)