gitpoint/git-point

Migration to styled-components

Open

#532 opened on 2017年10月20日

GitHub で見る
 (28 comments) (5 reactions) (0 assignees)JavaScript (4,684 stars) (837 forks)batch import
:nail_care: styled-componentsgood for beginnershacktoberfesthelp wantedrefactor

説明

Here's a list based off @andrewda's list for adding unit tests to the app (https://github.com/gitpoint/git-point/issues/518), feel free to add/remove components if you think it's necessary.

For newcomers:

  1. Choose the component you want to style
  2. Comment here which component you'd like to work on
  3. We'll update this list with your name
  4. Make sure to include "before" and "after" screenshots in your submitted PR

Loaders

  • LoadingListItem (@machour - #790)
  • LoadingMembersList (unclaimed)
  • LoadingRepositoryListItem (unclaimed)
  • LoadingRepositoryProfile (unclaimed)
  • LoadingUserListItem (@machour - #791)
  • LoadingModal (@machour - #792)

Components

  • IssueListItem (@josenaranjo - #578)
  • RepositoryProfile (@shmesa22 - PR Pending)

Screens

issue

  • EditIssue (unclaimed)
  • IssueSettings (unclaimed)
  • NewIssue (unclaimed)
  • PullMerge (unclaimed)

repository

  • IssueList (unclaimed)
  • PullDiff (unclaimed)
  • PullList (unclaimed)
  • ReadMe (unclaimed)
  • RepositoryCodeList (unclaimed)
  • RepositoryFile (unclaimed)
  • Repository (@machour - #788)

Done:

  • Auth (@ZahraTee - #702)
  • Login (@machour - #787)
  • Notifications (@ZahraTee - #684)
  • Organization (@ZahraTee - #682)
  • Search (@Arjun-sna - #710)
  • User (@ZahraTee - #683)
  • Badge (@jpls93 – #535)
  • LoadingContainer (@machour - #782)
  • CodeLine (@josenaranjo – #561)
  • CommentInput (@shmesa22 – #596)
  • CommentListItem (@chinesedfan - #723)
  • DiffBlocks (@machour – #692)
  • EntityInfo (@MrLoh - #558)
  • ImageZoom (@MrLoh - #559)
  • InlineLabel (@binkpitch – #544)
  • IssueDescription (@josenaranjo - #563)
  • IssueEventListItem (@josenaranjo - #564)
  • LabelButton (@chinesedfan - #727)
  • LabelListItem (@pdong – #509)
  • Members (@shmesa22 - #606)
  • MentionArea (@binkpitch – #553)
  • NotificationIcon (@pdong – #510)
  • NotificationListItem (@LeoCp - #610)
  • ParallaxScroll (@shmesa22 - #607)
  • RepositoryListItem (@apoeco - #605)
  • RepositorySectionTitle (Useless component, see #730)
  • SectionList (@jamesg1 - #608)
  • StateBadge (@rkpasia - #715)
  • ViewContainer (@pdong – #508)
  • UserListItem (@shmesa22 - #601)
  • UserProfile (@chinesedfan – #724)
  • SearchBarAndroid (can't be migrated)

コントリビューターガイド

技術スタック
reactreact nativejavascript
領域
mobilefrontend
Issue 種別
refactor
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
React Native basicsstyled components syntax
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
80
調査方針
Examine previously migrated components in the 'Done' list, such as Badge (#535) or LoadingContainer (#782), to understand the styling pattern used with styled components. Choose an unclaimed component like EditIssue or IssueSettings from the list. Comment on the issue to claim it. Ensure to follow the existing structure in the codebase, likely in src/components/ or src/screens/. Include before and after screenshots in the PR.