ggml-org/whisper.cpp

max-len as a range or 'suggestion' to reduce dangling tokens

Open

#543 opened on 2023年2月27日

GitHub で見る
 (1 comment) (2 reactions) (0 assignees)C++ (49,693 stars) (5,535 forks)batch import
enhancementgood first issue

説明

suggestion that the max-len argument allow for some ambiguity of +- words/tokens or a nargs range instead of a hard int, so that the output files don't dangle a single word/token on successive timestamps.

Ex: Given the following output, it would probably be preferrable that the 2nd and 5th timestamp (there/job) would appear with the previous timestamp, possibly hard-wrapped to a second line in the cue, rather than alone.

` [00:06:23.160 --> 00:06:27.000] The other district where Pat was over

[00:06:27.000 --> 00:06:27.000] there,

[00:06:27.000 --> 00:06:28.380] also they know her.

[00:06:28.380 --> 00:06:31.680] So I think they were doing a very good

[00:06:31.680 --> 00:06:32.400] job.

[00:06:32.400 --> 00:06:35.750] - So only those two candidates were the

[00:06:35.750 --> 00:06:36.160] only ones `

コントリビューターガイド

技術スタック
cpp
領域
backendcli
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
Familiarity with C++Understanding of whisper.cpp command line parsing
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
60
調査方針
First, examine how the max len argument is currently parsed and applied in main.cpp. The issue suggests allowing a range or tolerance (e.g., an integer with a +/ value). Look at the argument parsing code, likely using argparse or similar. Then, modify the logic to accept a range and adjust the output formatting to avoid dangling single words. The comment in the issue provides example output showing the problem; use that to test the change.