ggml-org/llama.cpp
GitHub で見るRefactor: Existing examples refactoring opportunities
Open
#7,559 opened on 2024年5月27日
help wantedrefactoring
Repository metrics
- Stars
- (110,169 stars)
- PR merge metrics
- (平均マージ 6d 8h) (30d で 389 merged PRs)
説明
I think a bigger advantage would be to do some refactoring in the existing examples and "hide" some of the state for sampling and KV cache management that we expose behind the common API
- Hide some state for sampling (unsure what this mean)
- Key Value cache management should be abstracted away behind the common API
- @ngxson suggest restructuring the help message in gpt_params_print_usage() to improve help message clarity
If there is any other aspect of the example which is currently a pain point for developer grokking, feel free to also suggest some so it can be added here.