ggml-org/llama.cpp

llama : integer type consistency in `llama.h`

オープン

#4,574 opened on 2023/12/21

 (4 件のコメント) (4 件のリアクション) (0 人の担当者)C++ (21,764 件のフォーク)batch import
enhancementgood first issuerefactoringroadmap

Repository metrics

Stars
 (124,134 個のスター)
PR merge metrics
 (平均マージ 6d 8h) (30d で 389 merged PRs)

説明

Feature Description

llama.h should prefer to use sized (always) + signed (mostly) integers.

Motivation

The integer types in llama.h right now are.

Count Type
33 int
10 int32_t
24 uint32_t
2 int64_t
2 uint64_t

In #4540 there was a discussion around preferences for integer types on new methods.

Avoiding int makes cross platform code simpler at essentially no cost. Signed makes arithmetic simpler at the cost of some bits if you need something large.

Possible Implementation

  1. Change all int's to int32_t
  2. As code changes try to prefer signed integers.

We could also do some higher-impact things, but I'd take the lower-impact slower changes over a large find-and-replace.

コントリビューターガイド