getredash/redash

Can't delete a data source if one of the queries references query result from it but uses a different data source

Open

#3,843 opened on 2019年5月29日

GitHub で見る
 (6 comments) (1 reaction) (1 assignee)Python (24,845 stars) (4,236 forks)batch import
BackendBughelp wanted

説明

Issue Summary

When you have the following situation:

Query A references query result from data source A, but itself references data source B.

You will not be able to delete data source A, because it will fail to delete the query results using it.

Steps to Reproduce

The way the above can happen is if:

  1. You execute query A while it uses data source A and update it to use data source B.
  2. If the data source update happens right after this query was executed but before we actually update the query result reference.

It's an edge case, but happened already twice for people who reported it.

The correct solution here is to update the latest_query_data_id reference to get nullified if the query result is deleted.

Technical details:

  • Redash Version: 7

コントリビューターガイド

技術スタック
python
領域
backend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Python programmingSQLAlchemy ORMDatabase concepts
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
45
調査方針
Examine the QueryResult model and the deletion logic in redash/models/ init .py around lines 304-309. The issue suggests nullifying the latest query data id when a query result is deleted. Review the database constraints and ensure no foreign key issues. Consider adding a migration if needed. Also check if there are any existing tests for this scenario.