getredash/redash

Allow name and email for user added by Remote User Auth to be different

Open

#1,648 opened on 2017年3月2日

GitHub で見る
 (3 comments) (0 reactions) (0 assignees)Python (24,845 stars) (4,236 forks)batch import
Backendenhancementhelp wanted

説明

Issue Summary

I'm trying to use Active Directory LDAP through remote_user_auth module. Currently there is no way to set different redash user name from mail address. So now my redash user accounts have mail address for both name and mail. Also, if user logs in with just the username or username@domain, the mail address is not correct and the alarm mail won't work.

Technical details:

To solve this, I guess we have to add another environment variable besides REMOTE_USER_HEADER.

Does it make sense to you to add variable like REMOTE_MAIL_HEADER, and use it like

name = REMOTE_USER_HEADER
email = REMOTE_MAIL_HEADER || REMOTE_USER_HEADER
create_and_login_user(current_org, name, email)

instead of

email = REMOTE_USER_HEADER
create_and_login_user(current_org, email, email)
  • Redash Version:Current Head
  • Browser/OS:Chrome
  • How did you install Redash:Docker

コントリビューターガイド

技術スタック
python
領域
authenticationbackend
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
basic Python knowledgefamiliarity with Redash authentication
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
65
調査方針
The issue proposes adding a new environment variable REMOTE MAIL HEADER to separate the user's name and email. Start by exploring the remote user auth module in the Redash codebase (likely under redash/authentication/). Review the current implementation of create and login user and how REMOTE USER HEADER is used. Then, implement the change to allow optional REMOTE MAIL HEADER, falling back to REMOTE USER HEADER for email. Update documentation and environment variable configuration accordingly. The issue's comment #1648 provides a clear code snippet to guide the implementation.