geoman-io/leaflet-geoman

Types fix (for crucial for react-leaflet users)

Open

#1,515 opened on 2024年9月19日

GitHub で見る
 (6 comments) (0 reactions) (0 assignees)JavaScript (1,933 stars) (404 forks)batch import
help wantedtypescript

説明

Hey! I'm using the free version with react-leaflet, and all seems to work quite well but there is one main problem which is types of event handlers. The type definitions for pm event is on interface Evented, while for react-leaflet users, the event handler's prop type (which are passed to each layer's component) are inferred LeafletEventHandlerFnMap. So far, I have built my own leaflet.d.ts file to extend the type infer to match what geoman is adding. I'd for it to come by default or listen to other possible solutions from the community

コントリビューターガイド

技術スタック
javascripttypescriptreact
領域
developer experiencefrontend
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
active
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
TypeScriptReact Leaflet
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
70
調査方針
Check the existing type definitions in the repository, particularly the Evented interface and the type maps for event handlers. Look at how react leaflet's type inference works for leaflet event handlers. The goal is to extend the existing PM event types to be included in the default EventHandlerFnMap for react leaflet compatibility. See comments in issue #1515 for user provided workaround. Files to examine: likely src/types.ts or similar typings files.