frintjs/frint

Maintenance: Upgrade to React v16

Open

#435 opened on 2018年7月16日

GitHub で見る
 (4 comments) (0 reactions) (0 assignees)JavaScript (746 stars) (37 forks)batch import
help wantedproposal

説明

Currently

Our API of frint-react is based on the context API of React v15.

React v16 still supports the old (v15) context API in deprecated mode, but also makes room for additional improvements.

It has also introduced APIs like getDerivedStateFromProps , making way for better async rendering (while also deprecating componentWillReceiveProps).

Proposal

We already have some additional proposals which make the API of FrintJS more simpler and stays close to the Component lifecycle where possible. Making it even easier to migrate to React v16:

  • #424: Access to app instance synchronously
  • #428: Region component with render prop support
  • #433: MountApp component
  • #436: Pass Region's props to Child Apps' root Components directly

While migrating to React v16, we can:

  • Drop observe HoC
  • Drop data prop in Region component
  • Drop RegionService

Because parent props as a stream would be difficult to access, since componentWillReceiveProps is already deprecated and will be gone in React v17.

It will have to be a breaking change.

コントリビューターガイド

技術スタック
reactjavascript
領域
frontend
Issue 種別
refactor
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-2 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
React v15 API knowledgeUnderstanding of frint reactComponent lifecycleAsync rendering concepts
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
25
調査方針
The issue requires upgrading frint react to React v16, which involves dropping the `observe` HoC, `data` prop in Region, and RegionService. It also references sub issues #424, #428, #433, #436. Contributors should first understand the current React v15 context API usage and then replace deprecated lifecycle methods like componentWillReceiveProps with getDerivedStateFromProps. It would be helpful to review the linked PRs that were already completed (e.g., #428, #436) to understand the new patterns. Since this is a breaking change, careful testing is needed.