fossasia/visdom

Properties box not updating

クローズ

#693 opened on 2019/12/11

 (3 件のコメント) (0 件のリアクション) (1 人の担当者)Python (1,152 件のフォーク)batch import
bughelp wanted

Repository metrics

Stars
 (9,831 個のスター)
PR merge metrics
 (平均マージ 9d 12h) (30d で 116 merged PRs)

説明

Bug Description When I trigger an update with viz.properties(), the window does not update.

Reproduction Steps Enter steps to reproduce the behavior:

  1. In python, run viz.properties([...], win='mywin')
  2. Open visdom in the browser
  3. Update the window with viz.properties([...], win='mywin')
  4. The property window does not update
  5. Refresh the browser. The property window contains the correct data.

Expected behavior The property window should update with new values.

Screenshots N/A

Client logs: The javascript console shows a warning:

main.js?v=47fc3afa811b358b354df09184e392e7:19 Warning: validateDOMNesting(...): <tr> cannot appear as a child of <table>. Add a <tbody> to your code to match the DOM tree generated by the browser.

However, I tested a patched version with <tbody> and it still had the update bug, even though the warning went away. So it looks like this not an issue.

I added some console.log statements inside of the render() functions, and it looks like the pane is re-rendering with the correct values. Somehow that update is not being reflected in the DOM.

Server logs: N/A

Additional context Using Chrome 78.0.3904.108 on Mac. Using visdom 0.1.8.9

コントリビューターガイド