flipace/horizon-react

Error responses from websocket are swallowed

オープン

#14 opened on 2016/07/28

 (2 件のコメント) (0 件のリアクション) (1 人の担当者)JavaScript (5 件のフォーク)github user discovery
bugenhancementhelp wanted

Repository metrics

Stars
 (112 個のスター)
PR merge metrics
 (30d に merged PR はありません)

説明

At the moment websocket error responses get swallowed and I have to manually inspect the messages to see what's wrong.

I've attempted to do:

collection.update(formData).subscribe(
  (d) => console.log('DONE', d),
  (err) => console.error(err),
)

Within my client code and changing https://github.com/flipace/horizon-react/blob/0806ede99abd4153117d6191dc10f9cce5bfbd20/src/components/subscribe.js#L206 to:


this.subscriptions[name] = {
  subscription: query
    .watch()
    .subscribe(
      this.handleData.bind(this, name),
      err => console.error(err)
    }),
  query: query._query
};

Neither of these will receive the error response. It's also not received by handleData (https://github.com/flipace/horizon-react/blob/0806ede99abd4153117d6191dc10f9cce5bfbd20/src/components/subscribe.js#L221)

Any guidance on how to go about this would be appreciated.

コントリビューターガイド