firebase/extensions

[storage-resize-images] The resize function is called twice for each uploaded image

オープン

#932 opened on 2022/03/31

 (3 件のコメント) (1 件のリアクション) (0 人の担当者)TypeScript (431 件のフォーク)github user discovery
extension: storage-resize-imagesgood first issuepending-interesttype: feature request

Repository metrics

Stars
 (976 個のスター)
PR merge metrics
 (平均マージ 7d 11h) (30d で 3 merged PRs)

説明

[REQUIRED] Step 2: Describe your configuration

  • Extension name: storage-resize-images
  • Extension version: 0.1.26

[REQUIRED] Step 3: Describe the problem

The resize function is called twice for each uploaded image.

Steps to reproduce:

  1. Install the extension with any configuration
  2. Upload an image to the storage
  3. The function will be triggered and it will resize the image and save it back to the storage successfully.
  4. The function will be triggered again (this time for the newly added resized image).
  5. The function will log File is already a resized image, no processing is required and will stop executing.

While this works totally and there are no errors or crashes, this causes a lot of unnecessary function calls. Imagine that I configure the extension to resize each image to multiple sizes (e.g. 200x200, 400x400, 800x800). This will cause 4 function calls for each image and 3 of them are unnecessary.

I suggest adding the ability to set different buckets for source and destination. That way I can create a separate bucket named images-to-resize for example, and the resized images will be stored in the other specified bucket.

Expected result

To trigger the resize function once for each image.

Actual result

The resize function is called multiple times for each image.

コントリビューターガイド