finos/morphir-elm

Remove Field from value expressions in the IR and use FieldFunction with Apply as a replacement

オープン

#156 opened on 2020/09/17

 (0 件のコメント) (0 件のリアクション) (0 人の担当者)Elm (69 件のフォーク)auto 404
enhancementgood first issueir-simplification

Repository metrics

Stars
 (51 個のスター)
PR merge metrics
 (PR metrics pending)

説明

Currently the IR has both Field and FieldFunction as values in the IR. The corresponding example in Elm would be a.foo vs. .foo. The idea is that a.foo can be represented as .foo a (applying the .foo function to a). The latter is more generic and the former is basically just a special combination of FieldFunction and Apply therefore it's accidental complexity which should be removed.

The specific change is to remove Field: https://github.com/finos/morphir-elm/blob/5e18e70bd4631aea1d1b677be04b62de3069a5eb/src/Morphir/IR/Value.elm#L90

And replace throughout the codebase using the following substitution rule:

Field a subjectValue fieldName -> Apply a (FieldFunction a fieldName) subjectValue

コントリビューターガイド