felangel/bloc
refactor: stop losing the original stack trace from dart 2.16
クローズ
#2,995 opened on 2021/11/21
examplegood first issuerefactor
Repository metrics
- Stars
- (12,452 個のスター)
- PR merge metrics
- (平均マージ 2d 22h) (30d で 5 merged PRs)
説明
You must stop losing the original source stack trace like this (just for example):
it's big trouble, to read exceptions without source stacktraces, especially in crashlytics or sentry like logs
from dart 2.16 you must use Error.throwWithStackTrace like this:
//@dart=2.16
...
} on FirebaseAuthException catch (e, stackTrace) {
Error.throwWithStackTrace(
SignUpWithEmailAndPasswordFailure.fromCode(e.code),
stackTrace,
);
}
also, instead:
} catch (_) {
you must write:
} on Object {
or:
} on Object catch (error, stackTrace) {