facundoolano/google-play-scraper

Don't mutate options objects

オープン

#238 opened on 2018/06/02

 (1 件のコメント) (0 件のリアクション) (0 人の担当者)JavaScript (723 件のフォーク)github user discovery
buggood first issue

Repository metrics

Stars
 (2,948 個のスター)
PR merge metrics
 (平均マージ 103d 2h) (30d で 4 merged PRs)

説明

Most of the methods take an options object and then mutate by setting default values, like here. This is not a good practice, since the methods don't own those objects and are introducing unexpected side effects. Use Object.assign instead to make copies of the options.

コントリビューターガイド