facebookresearch/hydra
GitHub ã§èŠã[Bug][configen] Generates unquoted str defaults when type hints include Optional[ ]
Open
#1,174 opened on 2020幎11æ30æ¥
bugconfigenhelp wantedtriage
Repository metrics
- Stars
- Â (7,539 stars)
- PR merge metrics
-  (å¹³åããŒãž 37d 6h) (30d 㧠25 merged PRs)
説æ
ð Bug
Almost identical issue to: #1071 except on a new edge case.
Configen will create fields typed with Optional[str], but if there's a default value which is a str type, it will not include it in quotes. We should also test other supported Type hint permutations.
Ex:
Generates the field
weights_summary: Optional[str] = top
instead of the desired:
weights_summary: Optional[str] = "top"
To reproduce
git clone https://github.com/romesco/hydra-lightning
configen --config-dir=configen/conf
Will create PR similar to #1072 for fix.
System information
- Hydra Version :
configen==0.9.0dev4 - Python version : 3.8.6
- Virtual environment type and version : pyenv-virtualenv 1.2.20
- Operating system : Ubuntu 18.04