facebookexperimental/Recoil

useRecoilCallback batched set calls update state incorrectly

Open

#1,935 opened on 2022年8月5日

GitHub で見る
 (14 comments) (0 reactions) (0 assignees)JavaScript (19,428 stars) (1,151 forks)batch import
bughelp wanted

説明

We've been using Recoil quite extensively and believe we have encountered a bug with useRecoilCallback and state updating.

There is a rootState atom that we want to update via a useRecoilCallback that contains multiple set calls. If the set calls within useRecoilCallback try to set the recoil state of rootState directly or through a single selector layer, the final rootState is as expected. However, if there is more than one layer of selector dependencies, it is only the last set that has a result on rootState.

Here is the CodeSandbox.

Expected: All steps change their state from ['1', '2', '3'] to ['one', 'two', 'three'] Result: The only step changing the state is the last one for which set has run. In effect: ['1', '2', '3'] changes to ['1', '2', 'three']

コントリビューターガイド

技術スタック
javascripttypescriptreact
領域
frontend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
4
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-2 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
active
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
React basicsRecoil fundamentalsSelector dependencies
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
25
調査方針
Examine the implementation of useRecoilCallback in the Recoil source code, specifically how batched set calls are handled. Investigate how selector dependency layers affect state updates. Check if there are any existing tests or related issues that discuss transaction batching. Consider whether the issue is in the selector cache invalidation logic.