facebookarchive/prepack

Review module ids: number vs string

Open

#852 opened on 2017年7月28日

GitHub で見る
 (0 comments) (0 reactions) (0 assignees)JavaScript (520 forks)batch import
help wantedpriority: low

Repository metrics

Stars
 (14,268 stars)
PR merge metrics
 (30d に merged PR はありません)

説明

The module system actually uses them interchangeably, assuming that numbers get converted to strings. However, in modules.js, we currently keep them around as number | string, as use that as indices into maps and elements of sets, where numbers and strings are getting distinguished.

We should systematically convert all modules ids to strings, and then consider replacing some of those Maps with plain Object.

コントリビューターガイド