Review all FatalError throws · facebookarchive/prepack#2020

2018-05-24T20:52:33.000Z

I've seen a few code snippets like this: ```js // todo: emit a diagnostic messsage throw new FatalError(); ``` This is problematic for two reasons: 1. User doesn't get any useful feedback. 2. Worse, on the command-line it will show up as an internal error, because there must not be a `FatalError` without a `CompilerDiagnostic` thingy having been issued. Concrete work items: 1. Review all places in the code where a `FatalError` is thrown, and make sure that a corresponding `CompilerDiagnostic` thingy was issued before. 2. Rethink best practices, as it is too easy to create mismatches between `FatalError` and `CompilerDiagnostic` (how did this get past code review?).

(2 comments) (2 reactions) (0 assignees)JavaScript (14,268 stars) (520 forks)batch import

bughelp wanted

説明

I've seen a few code snippets like this:

    // todo: emit a diagnostic messsage
    throw new FatalError();

This is problematic for two reasons:

User doesn't get any useful feedback.
Worse, on the command-line it will show up as an internal error, because there must not be a FatalError without a CompilerDiagnostic thingy having been issued.

Concrete work items:

Review all places in the code where a FatalError is thrown, and make sure that a corresponding CompilerDiagnostic thingy was issued before.
Rethink best practices, as it is too easy to create mismatches between FatalError and CompilerDiagnostic (how did this get past code review?).

コントリビューターガイド

技術スタック: javascript
領域: developer experiencetooling
Issue 種別: refactor
難度: 3
推定時間: half day
活動状況: stale
明確さ: mostly clear
前提条件: Understanding of FatalError and CompilerDiagnostic in prepack
初心者向け度: 30
調査方針: Review all occurrences of `throw new FatalError()` in the prepack codebase. For each, check if a `CompilerDiagnostic` is emitted before the throw. The issue mentions that some places have a TODO comment without a diagnostic. Look at the linked PRs or comments for any prior discussion. Files likely include compiler error handling modules.