facebookarchive/prepack

Make Prepack heap graph visualization to be consistently with different serialization options

Open

#1,309 opened on 2018年1月2日

GitHub で見る
 (0 comments) (0 reactions) (0 assignees)JavaScript (14,268 stars) (520 forks)batch import
bughelp wantedwebsite

説明

Currently, Prepack heap graph visualization is based on the default Prepack mode so it may diverge from the real generated code when options are applied. For example, when --inlineExpressions is applied, many objects are inlined into its parent object so there is no identifier generated for it while heap visualization still shows their identifiers which is confusing.(Not sure what to show though).

Here are some options that may change the graph but not well tested:

  1. --inlineExpressions.
  2. --debugNames
  3. --additionalFunctions.
  4. --react

For this issue, we should a least fix for "--inlineExpressions" since it is default on website. Also, we should make heap visualization feature is disabled when "--additionalFunctions/--react" is specified since we haven't tested it yet.

コントリビューターガイド

技術スタック
javascript
領域
tooling
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
Prepack serialization optionsHeap graph visualization code
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
20
調査方針
Start by examining the heap graph visualization code in the Prepack repository. Look for the module responsible for generating the visualization and see how it currently uses serialization options, particularly inlineExpressions. Check the options parsing code to understand how to conditionally enable/disable features. Also, review any existing tests for visualization consistency. Since the repository is archived, consider whether changes are still desired, but for this issue, the goal is to make the visualization reflect the actual output of different options.
Make Prepack heap graph visualization to be consistently with different serialization options · facebookarchive/prepack#1309 | Good First Issue