facebookarchive/draft-js

Out of sync selectionState within decorator strategy

Open

#484 opened on 2016年6月23日

GitHub で見る
 (4 comments) (1 reaction) (0 assignees)JavaScript (22,554 stars) (2,646 forks)batch import
help wantedquestion

説明

It would be nice for developers to be able to get the selectionState within a decorator strategy. When trying to do this with this.state.editorState.getSelection() inside of the decorator, the data seems to be out of sync.

Try creating a decorator with this strategy

strategy: (contentBlock, callback) =>  {
     const editorStateText = this.state.editorState.getCurrentContent().getPlainText();
     const contentBlockText = contentBlock.getText();

     console.log(editorStateText);
     console.log(contentBlockText);

     //...
},

You will notice that contentBlockText will be one character(or keystroke) ahead of editorStateText when typing.

Does getting an up-to-date selectionState within the decorator strategy seem like a good idea?

コントリビューターガイド

技術スタック
javascriptreact
領域
frontend
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Familiarity with Draft.js decorator strategiesUnderstanding of React stateJavaScript basics
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
30
調査方針
The issue describes a mismatch between the selectionState obtained inside a decorator strategy and the actual state. Investigate Draft.js source code for decorator strategy implementation, likely in src/component/decorators/. The problem may be that the strategy receives a snapshot of the editorState rather than the current one. A possible fix is to pass the latest editorState or provide a callback. Since the repository is archived, consider forking the project or exploring alternative text editors like Slate or Lexical.
Out of sync selectionState within decorator strategy · facebookarchive/draft-js#484 | Good First Issue