facebookarchive/draft-js

moveSelectionBackward warning in production

Open

#1,840 opened on 2018年8月20日

GitHub で見る
 (5 comments) (2 reactions) (0 assignees)JavaScript (22,554 stars) (2,646 forks)batch import
help wanted

説明

Do you want to request a feature or report a bug? bug

What is the current behavior? backspacing in the editor causes the following warning in dev environment:

Draft.js:5665 Warning: moveSelectionBackward should only be called with a collapsed SelectionState

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. You can use this jsfiddle to get started: https://jsfiddle.net/stopachka/m6z0xn4r/.

  1. Open the official tweet.html example.
  2. Type "abcdefg"
  3. Press backspace Observe each time backspace is pressed there is a warning in the console log.

The warning is only shown in dev env. I haven't found any user facing issue caused by this.

What is the expected behavior? Shouldn't have warning in console log.

Which versions of Draft.js, and which browser / OS are affected by this issue? Did this work in previous versions of Draft.js?

There isn't this warning on the master of May 16, 2018, so it could be a regression.

コントリビューターガイド

技術スタック
javascriptreact
領域
frontend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
under 1 hour
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
basic knowledge of Reactfamiliarity with Draft.js
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
50
調査方針
The warning 'moveSelectionBackward should only be called with a collapsed SelectionState' appears in dev mode in Draft.js. To investigate, search for the string 'moveSelectionBackward' in the source code. Look at the function that calls it and ensure it checks for collapsed selection before calling. The issue might be in the 'handleBackspace' or related method. Since the repository is archived, consider if a fix is still feasible or propose a workaround.