facebookarchive/draft-js

Test to verify focus/scroll behavior

オープン

#1,402 opened on 2017/09/22

 (1 件のコメント) (0 件のリアクション) (0 人の担当者)JavaScript (2,646 件のフォーク)batch import
help wantedtest coverage

Repository metrics

Stars
 (22,554 個のスター)
PR merge metrics
 (PR metrics pending)

説明

We have twice now had an issue where a change in Chrome breaks the scroll/focus behavior of Draft. See issues #14 and now https://github.com/facebook/draft-js/issues/1381.

It might not be easy, but I'd really like to get this covered by a test, so that we can know if/when it breaks again. Ideally would like both a unit test for focusNode in fbjs and a test that only uses the public API of Draft.js and reproduces an example similar to the one given in https://github.com/facebook/draft-js/issues/1381 .

It's true that these test would only start failing when run in the browser that has the inconsistency, but still would make it faster to verify and fix this type of problem.

コントリビューターガイド