facebookarchive/draft-js

EditorState.set() Selection Handling

Open

#1,161 opened on 2017年4月22日

GitHub で見る
 (1 comment) (0 reactions) (0 assignees)JavaScript (22,554 stars) (2,646 forks)batch import
documentationhelp wanted

説明

Do you want to request a feature or report a bug?

Bug (or documentation issue)

What is the current behavior?

EditorState.set() doesn't handle selection.

Steps to reproduce: https://jsfiddle.net/7bsqzmfg/10/

What is the expected behavior?

Either EditorState.set() should handle selection or we should mention that it is not supposed to handle selection on the docs.

Which versions of Draft.js, and which browser / OS are affected by this issue? Did this work in previous versions of Draft.js?

Draft.js 0.10.0 Google Chrome 57.0.2987.133 macOS Sierra 10.12.3 (16D32)

コントリビューターガイド

技術スタック
javascriptreact
領域
frontenddocumentation
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
Basic understanding of ReactFamiliarity with Draft.js EditorState
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
40
調査方針
The issue reports that EditorState.set() does not handle selection, with a reproduction in JSFiddle. The repository is archived (facebookarchive/draft js), so any fix would need to be applied to a fork. To proceed, locate the EditorState.set() method in the source (likely src/model/immutable/EditorState.js) and examine how selection is currently handled. Check if the method should preserve selection from the previous state or if the documentation should clarify that selection is not handled. Also review any existing comments in the issue or related issues. Consider both fixing the behavior and updating documentation accordingly.