facebookarchive/atom-ide-ui
GitHub で見るAllow code format providers to return null to 'fall through'
Open
#26 opened on 2017年9月13日
code formatenhancementhelp wanted
Repository metrics
- Stars
- (937 stars)
- PR merge metrics
- (30d に merged PR はありません)
説明
Code format providers are currently forced to return something: https://github.com/facebook-atom/atom-ide-ui/blob/master/modules/atom-ide-ui/pkg/atom-ide-code-format/lib/types.js
However, this makes it difficult to have multiple formatting providers for the same document, since we only use the one with the highest priority.
Instead, we should use ProviderRegistry.getAllProvidersForEditor (e.g. on https://github.com/facebook-atom/atom-ide-ui/blob/master/modules/atom-ide-ui/pkg/atom-ide-code-format/lib/CodeFormatManager.js#L257) and take the first one with a non-nullable result.
cc @damieng