facebookarchive/atom-ide-ui

Datatip source code links

Open

#183 opened on 2018年3月6日

GitHub で見る
 (1 comment) (0 reactions) (0 assignees)JavaScript (937 stars) (110 forks)batch import
datatipshelp wanted

説明

Description

I have put a source link in the markdown contents of a datatip. Namely the Atom Core URL to open a file in Atom editor given its path: [This is a link](atom://core/open/file?filename=<path to file>) Atom Core links went in with #15935. I have also opened the same issue against core Atom #16888 I'm not exactly sure which package is responsible for this to work...

The problem is that ATom URL handlers are not supported in MD datatip/hover or any rendered MD

Expected Behavior

Should invoke Atom URL handler for atom:// URL

Actual Behavior

Nothing happens. Expects a http:// protocol which is handled by opening external browser

Versions

  • Atom: 1.25-beta2 and all predecessors
  • Client OS: Mac OSX
  • atom-ide-ui: 0.9.2

Additional Details

Looking for directions... What to look at if I am to provide a patch for this

コントリビューターガイド

技術スタック
javascripthtml
領域
frontend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
Understanding of Atom's URL handler systemFamiliarity with markdown rendering in Atom
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
30
調査方針
Investigate how markdown is rendered in atom ide ui datatips, likely in a component that processes the markdown content. Look at the handling of http:// URLs to see how they open an external browser. To support atom:// URLs, you'll need to intercept those links and invoke Atom's native URL handler. Check the core Atom issue #16888 and commit #15935 for context on how atom:// handlers were implemented. The relevant files are likely in the 'lib' directory of the atom ide ui package, possibly in a markdown renderer or link handler module.