facebook/zstd

zstd fails to process some filenames on Windows [we need a hero]

Open

#3,882 opened on 2024年1月24日

GitHub で見る
 (19 comments) (0 reactions) (0 assignees)C (27,100 stars) (2,481 forks)batch import
help wanted

説明

Windows 7 x64, zstd 1.5.5

$ dir /b
birds.txt
pájaros.txt
vögel.txt
птицы.txt

$ zstd *.*
zstd: can't stat pajaros.txt : No such file or directory -- ignored
zstd: can't stat vogel.txt : No such file or directory -- ignored
  2 files compressed : 85.71% (  3.00 KiB =>   2.57 KiB)
 
$ dir /b *.zst
birds.txt.zst
птицы.txt.zst

@Cyan4973 said zstd doesn't do anything special, it uses the C standard fopen() function. This should be naturally compatible with any utf-8 character set. But I suspect Windows does something different with the character set, so there might be a need to employ other non-portable Windows variants of > fopen for these scenarios.

コントリビューターガイド

技術スタック
c
領域
cli
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
4
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
3-5 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
active
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
C programmingWindows API knowledgeunderstanding of Unicode encodingfamiliarity with cross platform compilation
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
20
調査方針
The issue is that zstd fails to process filenames with non ASCII characters on Windows because it uses the C standard fopen() which does not handle UTF 8 filenames on that platform. The fix likely involves using Windows specific wide character file functions like wfopen() or the newer CreateFileW() API. Look at the source code in programs/fileio.c where file opening is handled, and investigate how to conditionally use the appropriate function based on the WIN32 macro. Refer to the maintainer's comment in the issue for guidance.