Enable `unexported-return` linter rule · etcd-io/etcd#18370

(23 comments) (0 reactions) (2 assignees)Go (51,701 stars) (10,352 forks)batch import

area/testinghelp wantedpriority/important-longtermtype/cleanup

説明

What would you like to be added?

There are two remaining linter rules that we haven't enabled but are left as TODO (./tools/.golangci.yaml): exported and unexported-return. The former will have significant changes to exported functions and interfaces. The latter, even though it impacts exported structs, it's for the better (it exposes them without breaking client implementations).

I suggest breaking the pull requests into small tasks like we did on #17578.

The following modules have warnings to be addressed:

Refer to the attached log file with the result from KEEP_GOING_MODULE=true make verify-lint.

Why is this needed?

To improve the quality of the code.

コントリビューターガイド

技術スタック: go
領域: backenddeveloper experiencetooling
Issue 種別: refactor
難度: 3
推定時間: over 1 week
活動状況: active
明確さ: clear
前提条件: Go programming basicsFamiliarity with static analysis toolsUnderstanding of exported vs unexported in Go
初心者向け度: 10
調査方針: The issue is a meta issue to enable the `unexported return` linter rule across multiple modules in etcd. To contribute, pick a module with pending work (e.g., pkg, client/pkg, client/v3) and run `KEEP GOING MODULE=true make verify lint` to generate warnings. Fix each warning by ensuring that exported functions that return unexported types either export the type or refactor the function. Refer to the attached log file and the pattern set by previous PRs like #18645 and #19052.