enzymejs/enzyme

getDerivedStateFromProps called from setState

Open

#2,078 opened on 2019年4月2日

GitHub で見る
 (2 comments) (3 reactions) (0 assignees)JavaScript (19,979 stars) (2,016 forks)batch import
bughelp wanted

説明

Current behavior

getDerivedStateFromProps is being called from within setState, instead of before render, which overwrites the state and is inconsistent with react behavior. Please see attached codesandbox. There is a FloatInput.spec.js file with a unit test to show the behavior.

Expected behavior

getDerivedStateFromProps should be called before render not from setState.

Your environment

https://codesandbox.io/s/vqrm0r0r30

API

  • [x ] shallow
  • mount
  • render

Version

library version
enzyme 3.9.0
react 16.8.3
react-dom 16.8.3
react-test-renderer
adapter (below)

Adapter

  • [x ] enzyme-adapter-react-16
  • enzyme-adapter-react-16.3
  • enzyme-adapter-react-16.2
  • enzyme-adapter-react-16.1
  • enzyme-adapter-react-15
  • enzyme-adapter-react-15.4
  • enzyme-adapter-react-14
  • enzyme-adapter-react-13
  • enzyme-adapter-react-helper
  • others ( )

コントリビューターガイド

技術スタック
reactjavascript
領域
testing
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
ReactenzymeJavaScript
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
60
調査方針
Examine the enzyme shallow renderer implementation, specifically how getDerivedStateFromProps is invoked. Review the provided codesandbox (https://codesandbox.io/s/vqrm0r0r30) and the FloatInput.spec.js test file. The issue indicates that getDerivedStateFromProps is called from setState instead of before render. Look at the adapter for React 16 (enzyme adapter react 16) to identify where the lifecycle method is called incorrectly. Ensure the fix aligns with React's behavior where getDerivedStateFromProps should be called during the render phase, not from state updates.